Add appveyor configuration file #27
Conversation
appveyor.yml
Outdated
| test_script: | ||
| - node --version | ||
| - npm --version | ||
| - IF %nodejs_version% EQU 7 npm run travis:lint |
There was a problem hiding this comment.
linting does not need to be done on both Travis and Appveyor. It only depends on the source code, which is the same. I would remove it from here
There was a problem hiding this comment.
@stof I just followed the configuration that was given in travis config file.
If we decide on not including this I can remove it
appveyor.yml
Outdated
| matrix: | ||
| - nodejs_version: "6" | ||
| - nodejs_version: "7" | ||
| - nodejs_version: "8" |
There was a problem hiding this comment.
Do we actually need to test all node versions on Appveoyr as well ? I don't think it is worth it. AFAIK, Appveoyr is not as good as Travis at handling multiple jobs (especially regarding cache, even though you don't use it yet).
There was a problem hiding this comment.
@stof I agree, I just followed the specs as given by package.json which states >= 6.
I can change to only test on 6 if that is what we desire
|
@weaverryan I've just enabled Appveyor on symfony/webpack-encore |
|
@DaRamirezSoto Awesome! The build is running great - it looks like it's the one failure you mentioned over and over again. I'll merge so that I can open a PR to get rid of that :). Thanks! @fabpot I tried to enabled it yesterday through my account, but it gave the project a |
|
@weaverryan hehe, AppVeyor works very differently from Travis. So, the URL is https://ci.appveyor.com/project/fabpot/webpack-encore |
Added a configuration file for AppVeyor tried to mimic how it was defined in travis configuration file.
This is first time for me using AppVeyor so it defiantly need some more experienced eyes.